Bump rexml to v3.3.2 #139
Open
Bump rexml to v3.3.2 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ Gem::Specification.new do |gem| | |||
| gem.add_dependency 'actionmailer', '>= 6.1' | |||
| gem.add_dependency 'letter_opener', '~> 1.9' | |||
| gem.add_dependency 'railties', '>= 6.1' | |||
| gem.add_dependency 'rexml' | |||
| gem.add_dependency 'rexml', '~> 3.3.2' | |||
There was a problem hiding this comment.
This will lock us to the 3.3.x line, meaning if/when 3.4.x is released, this constraint won't allow folks to upgrade to it. So I think something like this might be better:
Suggested change
| gem.add_dependency 'rexml', '~> 3.3.2' | |
| gem.add_dependency 'rexml', '>= 3.3.2' |
Though, I also wonder if this is more of a thing that users of this gem should worry about, since they might have specific version needs/constraints for rexml.
🤔💭
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REXML gem before 3.3.1 has some DoS vulnerabilities when it parses an XML that has many specific characters such as
<,0and%>.The REXML gem 3.3.2 or later include the patches to fix these vulnerabilities.
GHSA-4xqq-m2hx-25v8