Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove --reversed-vpn for cluster create #242

Merged
merged 1 commit into from
Jul 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cmd/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ func newClusterCmd(c *config) *cobra.Command {
clusterCreateCmd.Flags().Duration("healthtimeout", 0, "period (e.g. \"24h\") after which an unhealthy node is declared failed and will be replaced. [optional]")
clusterCreateCmd.Flags().Duration("draintimeout", 0, "period (e.g. \"3h\") after which a draining node will be forcefully deleted. [optional]")
clusterCreateCmd.Flags().Bool("encrypted-storage-classes", false, "enables the deployment of encrypted duros storage classes into the cluster. please refer to the user manual to properly use volume encryption. [optional]")
clusterCreateCmd.Flags().BoolP("reversed-vpn", "", false, "enables usage of reversed-vpn instead of konnectivity tunnel for worker connectivity. [optional]")
clusterCreateCmd.Flags().BoolP("autoupdate-kubernetes", "", false, "enables automatic updates of the kubernetes patch version of the cluster [optional]")
clusterCreateCmd.Flags().BoolP("autoupdate-machineimages", "", false, "enables automatic updates of the worker node images of the cluster, be aware that this deletes worker nodes! [optional]")
clusterCreateCmd.Flags().String("default-storage-class", "", "set default storage class to given name, must be one of the managed storage classes")
Expand Down Expand Up @@ -552,8 +551,6 @@ func (c *config) clusterCreate() error {
maintenanceBegin := "220000+0100"
maintenanceEnd := "233000+0100"

reversedVPN := strconv.FormatBool(viper.GetBool("reversed-vpn"))

version := viper.GetString("version")
if version == "" {
request := cluster.NewListConstraintsParams()
Expand Down Expand Up @@ -656,7 +653,8 @@ func (c *config) clusterCreate() error {
AdditionalNetworks: networks,
PartitionID: &partition,
ClusterFeatures: &models.V1ClusterFeatures{
ReversedVPN: &reversedVPN,
// always set reversed vpn for new clusters
ReversedVPN: pointer.Pointer("true"),
LogAcceptedConnections: &logAcceptedConnections,
DurosStorageEncryption: &encryptedStorageClasses,
},
Expand Down