Better error message if s3 deletion takes longer than 30s. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
changed the title
majst01
reviewed
May 31, 2024
| @@ -247,6 +249,9 @@ func (c *config) s3Delete() error { | |||
|
|
|||
| response, err := c.cloud.S3.Deletes3(request, nil) | |||
| if err != nil { | |||
| if errors.Is(err, context.DeadlineExceeded) { | |||
There was a problem hiding this comment.
Another approach would be to simply put this into background and tell the user that the deletion will take a while to complete
There was a problem hiding this comment.
So you want to keep the server connection open? Not sure if there are other timeouts involved which will cancel the request prematurely. 🤔
There was a problem hiding this comment.
No, this is obviously not possible with a cli :-)
majst01
approved these changes
Jun 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279.