Add --high-availability flag for cluster create and update
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
changed the title
--highavailability flag for cluster create and update
Gerrit91
changed the title
--highavailability flag for cluster create and update--high-availability flag for cluster create and update
|
maybe use flag |
Gerrit91
reviewed
Sep 26, 2024
Gerrit91
reviewed
Sep 26, 2024
cmd/cluster.go
Outdated
| @@ -673,6 +676,17 @@ WARNING: You are going to create a cluster that has no default internet access w | |||
| } | |||
| } | |||
|
|
|||
| if viper.IsSet("high-availability-control-plane") { | |||
| scr.ClusterFeatures.HighAvailability = &highAvailability | |||
| if err := genericcli.PromptCustom(&genericcli.PromptConfig{ | |||
There was a problem hiding this comment.
Check is missing if it the flag is set to true.
Gerrit91
reviewed
Sep 26, 2024
Gerrit91
approved these changes
Sep 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for toggling the HA control plane feature.