Allow updating firewall networks #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
changed the title
Gerrit91
changed the title
majst01
reviewed
Feb 4, 2021
cmd/ip.go
Outdated
| @@ -161,7 +161,7 @@ func ipStatic(args []string) error { | |||
|
|
|||
| if !viper.GetBool("yes-i-really-mean-it") { | |||
| fmt.Println("Turning an IP from ephemeral to static is irreversible. The IP address is not cleaned up automatically on cluster deletion. The address will be accounted until the IP address gets freed manually from your side.") | |||
| err = helper.Prompt("Are you sure? (y/n)", "y") | |||
| err = helper.Prompt("Are you sure? (y)", "y") | |||
There was a problem hiding this comment.
You're right, it should not be part of this PR. I made an issue why I think there is something problematic about the "no" answer: #52
majst01
reviewed
Feb 4, 2021
cmd/ip.go
Outdated
| @@ -192,7 +192,7 @@ func ipAllocate(args []string) error { | |||
|
|
|||
| if !viper.GetBool("yes-i-really-mean-it") { | |||
| fmt.Println("Allocating a static IP address costs additional money because addresses are limited. The IP address is not cleaned up automatically on cluster deletion. The address will be accounted until the IP address gets freed manually from your side.") | |||
| err := helper.Prompt("Are you sure? (y/n)", "y") | |||
majst01
approved these changes
Feb 5, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.