Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Waves.js works wrong when both <button> was disabled and <button> has child. #133

Closed
lixiaoyan opened this issue Jul 21, 2015 · 2 comments
Closed

Waves.js works wrong when both <button> was disabled and <button> has child. #133

lixiaoyan opened this issue Jul 21, 2015 · 2 comments
Labels
Bug

Comments

@lixiaoyan
Copy link

A very simple example: http://jsbin.com/gofewazula/edit?html,output.
When disabled <button> has child, and you clicked that child, ripple effect works wrong.
@lixiaoyan
Copy link
Author

Seem to be waves.js only checked the event.target.disabled, when I set child.disabled to true, all things works fine.

@fians fians added the Bug label Aug 16, 2015
fians pushed a commit that referenced this issue Aug 16, 2015
Prevent ripple appear when element has "disabled" property #133
51c0a56
@fians
Copy link
Owner

fians commented Aug 16, 2015

Well, I think I just make the ripple didn't show if there is disabled property on target element.

@fians fians closed this as completed Aug 16, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lixiaoyan @fians