Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

partitions, 3x1 3x2 and 3x3 spliting modes for big screens #122

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zuloo
Copy link

@zuloo zuloo commented Nov 14, 2013

great work! I added partitions, which I missed in your versions so far. While doing so I added some more split modes which are very useful on 27"+ screens...

@@ -484,23 +497,25 @@ - (void)updateStatusMenuShortcutForAction_:(ShiftItAction *)action keyCode:(NSIn
FMTLogDebug(@"updateStatusMenuShortcutForAction_:%@ keyCode:%ld modifiers:%ld", [action identifier], keyCode, modifiers);

NSMenuItem *menuItem = [statusMenu_ itemWithTag:kSIMenuUITagPrefix + [action uiTag]];
FMTAssertNotNil(menuItem);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrapped this into an if to prevent it from failing to load all the key-combos - there are no menuitems for the new shiftactions yet

@zuloo
Copy link
Author

zuloo commented Nov 14, 2013

I had to rearange the preference window - that makes up for round about 6000 changes - yes i used the visual editor. Maybe I will add all new shiftactions to mainmenu (would prefer a submenu), but I do not think this is absolutely neccessary ...

@fikovnik
Copy link
Owner

Thanks for the contribution. I'm gone for the next week, but then I will check the code and merge it in.

/cheers
Filip

@ameyec ameyec mentioned this pull request Mar 23, 2017
@cjcjameson
Copy link

#223 resolved this by providing a similar feature I think -- just waiting for a new release (and hopefully an update to the brew cask?) !

@VMelandri
Copy link

Any update here or on #223 ?
Any update on new release?

PS: Great work, I totally LOVE this tool!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants