Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ability to set minHeight and maxHeight for markdown field #11695

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Ability to set minHeight and maxHeight for markdown field #11695

merged 2 commits into from
Mar 5, 2024

Conversation

beholdr
Copy link
Contributor

@beholdr beholdr commented Mar 5, 2024 •
edited
Loading

Description

Ability to set minHeght and maxHeight for markdown field. Discussed here.

  • Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

  • composer cs command has been run.

Testing

  • Changes have been tested.

Documentation

  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label Mar 5, 2024
@danharrin danharrin added this to the v3 milestone Mar 5, 2024
@danharrin danharrin merged commit bb83a8b into filamentphp:3.x Mar 5, 2024
11 checks passed
@danharrin
Copy link
Member

Nice, thank you so much for following our code style so perfectly.

@geowrgetudor
Copy link

Thanks for this @beholdr . I didn't find the time to submit a PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.
3 participants
@beholdr @danharrin @geowrgetudor