Disable <x-filament::button> wire:navigate
#11700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to add
:allow-browser-navigation="false"to the<x-filament::button>component. Adding this attribute disables the addition ofwire:navigateeven when in SPA mode.Use case
For our package https://github.com/DutchCodingCompany/filament-socialite we'd like to disable browser-navigation for a specific button that sends the user to an external oauth provider, since browser-navigation is not allowed due to CORS restrictions. However, enabling SPA mode enables browser-navigation for all in-app routes (our route has a redirect so it is still counted as an in-app route, causing
wire:navigateto be added).