Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: boostd net commands #1941

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: boostd net commands #1941

merged 1 commit into from
Jul 25, 2024

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Jul 25, 2024 •
edited
Loading

The boostd net commands were using Lotus subcommand and this caused them to open Lotus API instead of Boost.


On Boost v2.3.0-rc2

lexluthr@Lexs-Mac boost % ./boostd net listen                                                                                    
/ip4/127.0.0.1/tcp/9090/p2p/12D3KooWQEeMearkt4N97yznJY9sS6ReNKoWyyoCm1H5CAZbegxy
/ip4/172.18.0.7/tcp/9090/p2p/12D3KooWQEeMearkt4N97yznJY9sS6ReNKoWyyoCm1H5CAZbegxy


Boost v2.3.0-rc1

lexluthr@Lexs-Mac boost % ./boostd net listen                     
/ip4/127.0.0.1/tcp/24000/p2p/12D3KooWQcrJrLxzHncnP7mnfuwv5hCxV8iLaHZukX93n9hBckdr
/ip6/::1/tcp/50382/p2p/12D3KooWQcrJrLxzHncnP7mnfuwv5hCxV8iLaHZukX93n9hBckdr


Fixed output

lexluthr@Lexs-Mac boost % ./boostd net listen
/ip4/127.0.0.1/tcp/24000/p2p/12D3KooWQcrJrLxzHncnP7mnfuwv5hCxV8iLaHZukX93n9hBckdr
/ip6/::1/tcp/50539/p2p/12D3KooWQcrJrLxzHncnP7mnfuwv5hCxV8iLaHZukX93n9hBckdr

@LexLuthr LexLuthr merged commit 5576d61 into main Jul 25, 2024
20 checks passed
@LexLuthr LexLuthr deleted the fix/net-commands branch July 25, 2024 13:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k