Funds logs pagination #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dirkmc
commented
Apr 5, 2022
dirkmc
commented
dirkmc
force-pushed
the
feat/funds-logs-pagination
branch
from
bcb98eb to
478b101
Compare
nonsense
reviewed
Apr 7, 2022
| @@ -81,9 +80,27 @@ func (f *FundsDB) InsertLog(ctx context.Context, logs ...*FundsLog) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (f *FundsDB) Logs(ctx context.Context) ([]FundsLog, error) { | |||
| func (f *FundsDB) Logs(ctx context.Context, first *time.Time, offset int, limit int) ([]FundsLog, error) { | |||
There was a problem hiding this comment.
Nit: Maybe it's just me, but I don't associate first with time. I suggest renaming this to cursor.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.