miner tests part 8 #362
Merged
miner tests part 8 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
ZenGround0
approved these changes
May 18, 2022
LesnyRumcajs
force-pushed
the
miner-deadlines-test-p8
branch
from
9966ddd to
0d32849
Compare
This was referenced May 18, 2022
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing tests from here.
cannot_remove_missing_partitionremoving_no_partitions_does_nothingfails_to_remove_partitions_with_faulty_sectorsterminate_proven_and_faultyterminate_unproven_and_faultyfails_to_terminate_missing_sectorfails_to_terminate_missing_partitionfails_to_terminate_already_terminated_sectorfaulty_sectors_expirecannot_pop_expired_sectors_before_provingFixed a particular fiasco in
Deadline::remove_partitionsthat was makingcannot_remove_missing_partitiontest fail. Also, there was some dead code condition that I thought would be nice to obliterate.