Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pass deal proposal instead of deal ID to OnDealExpiredOrSlashed #476

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jan 26, 2021

The deal ID may change if there is a reorg after the deal publish message lands on chain, so pass the deal proposal instead

@raulk raulk added the x/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs label Feb 25, 2021
@dirkmc dirkmc force-pushed the refactor/on-deal-exp-proposal branch from 6eea365 to c47cf53 Compare June 18, 2021 08:10
@dirkmc dirkmc force-pushed the refactor/on-deal-exp-proposal branch from c47cf53 to 9d7f83a Compare August 4, 2021 11:34
@dirkmc dirkmc merged commit 2e06ce3 into master Aug 4, 2021
@dirkmc dirkmc deleted the refactor/on-deal-exp-proposal branch August 4, 2021 11:38
@dirkmc dirkmc mentioned this pull request Aug 4, 2021
raulk added a commit that referenced this pull request Aug 16, 2021
raulk added a commit that referenced this pull request Aug 16, 2021
@dirkmc dirkmc mentioned this pull request Sep 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
x/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants