-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add batch request support #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question/comment. One nit on handling whitespace. Otherwise LGTM. Thanks!
* Add proper status codes to error responses * Add more unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
I'll merge this once it passes CI in lotus. |
Awesome, thank you. |
@Stebalien we'll probably want to get this deployed to Glif and other hosted providers to unblock ngram and others! |
I see PR didn't pass warning checks, should I create a new PR to fix it? |
This pull request adds support for batched requests in JSON-RPC v2 as described in the JSON-RPC 2.0 specification.
Changes:
Motivation:
Batched requests allow clients to send multiple requests in a single HTTP request, reducing overhead and allowing for more efficient communication. This is particularly useful in situations where multiple requests need to be made in a short period of time, such as when syncing data in real time.
Testing:
New unit tests have been added to cover the processing of batched requests. Additionally, manual testing has been performed to ensure that the implementation correctly handles a variety of batched request scenarios, including valid and invalid inputs.
Please provide any feedback or suggestions for improvement.