Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FVM: Implicit messages should fail on non-zero exit codes #8463

Closed
arajasek opened this issue Apr 11, 2022 · 0 comments
Closed

FVM: Implicit messages should fail on non-zero exit codes #8463

arajasek opened this issue Apr 11, 2022 · 0 comments
Assignees
@arajasek
Labels
P1 P1: Must be resolved
Milestone
Network v16

Comments

@arajasek
Copy link
Contributor

We currently handle FVM implicit messages the same way we do regular messages -- if the FVM returned an error, we do so, otherwise we successfully return (with a non-zero exitcode).

This doesn't match LegacyVM behaviour, which fails if cron / rewards messages fail in any way. We should match that behaviour.
@arajasek arajasek added the P1 P1: Must be resolved label Apr 11, 2022
@arajasek arajasek added this to the Network v16 milestone Apr 11, 2022
@arajasek arajasek self-assigned this Apr 11, 2022
@arajasek arajasek mentioned this issue May 26, 2022
Merged
5 tasks
@arajasek arajasek moved this from Todo to In Review in Network v16 (Skyr) - FVM M1 Upgrade May 26, 2022
Repository owner moved this from In Review to Done in Network v16 (Skyr) - FVM M1 Upgrade May 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@arajasek arajasek

Labels
P1 P1: Must be resolved
Projects
No open projects
Network v16 (Skyr) - FVM M1 Upgrade
Status: Done
Milestone
Network v16
Development

No branches or pull requests
1 participant
@arajasek