fvm: fail if implicit message fails #8734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/nv16 #8734 +/- ##
=============================================
- Coverage 40.72% 40.70% -0.02%
=============================================
Files 704 704
Lines 77228 77230 +2
=============================================
- Hits 31452 31438 -14
- Misses 40387 40399 +12
- Partials 5389 5393 +4
|
magik6k
approved these changes
May 27, 2022
chain/vm/fvm.go
Outdated
| } | ||
|
|
||
| if ret.ExitCode != 0 { | ||
| return applyRet, fmt.Errorf("implicit message failed with exit code: %d", ret.ExitCode) |
arajasek
force-pushed
the
asr/implicit-fail
branch
from
e6993d5 to
7ea661b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Resolves #8463
Proposed Changes
This is not strictly needed, since all existing callsites of
ApplyImplicitMessagecheck for a non-zero exit code and fail anyway. But nice to make it explicit!Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps