Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: shed: Add beneficiary commands #10037

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jan 17, 2023

Proposed Changes

Adding the ProposeChangeBeneficiary and ConfirmChangeBeneficiary commands to lotus-shed.

Having these commands in the lotus-shed makes it possible to propose and confirm beneficiary address changes without the need to import the keys into the lotus-node that the lotus-miner is connected to.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Add `ProposeChangeBeneficiary` and `ConfirmChangeBeneficiary` to lotus-shed
@rjan90 rjan90 requested a review from a team as a code owner January 17, 2023 11:49
@jennijuju
Copy link
Member

o propose and confirm beneficiary address changes without the need to import the keys into the lotus-node that the lotus-miner is connected to

cuious why is this something user would want?

@rjan90
Copy link
Contributor Author

rjan90 commented Jan 17, 2023

cuious why is this something user would want?

  • Owner and beneficiary address might be different entities/(potentially a smart contract)
  • Owner-addresses and beneficiary-addresses are usually not held on the lotus daemon that the lotus-miner is connected to for security reasons.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants