Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add a lotus-shed eth check-tipsets command. #10060

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

raulk
Copy link
Member

@raulk raulk commented Jan 19, 2023

This checks Eth API consistency by walking the chain backwards from HEAD and verifying that all data returned from eth_getBlockByNumber is consistent with eth_getBlockByHash. This helps us debug Eth JSON-RPC endpoint inconsistencies re: tipset CID.

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

This checks Eth API consistency by walking the chain backwards
from HEAD and verifying that all data returned from eth_getBlockByNumber
is consistent with eth_getBlockByHash.
@raulk raulk requested a review from a team as a code owner January 19, 2023 14:14
@geoff-vball geoff-vball merged commit e200df4 into release/v1.20.0 Feb 1, 2023
@geoff-vball geoff-vball deleted the raulk/eth-check-tipsets-cmd branch February 1, 2023 23:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants