Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: extend LOTUS_CHAIN_BADGERSTORE_DISABLE_FSYNC to the markset #10172

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: extend LOTUS_CHAIN_BADGERSTORE_DISABLE_FSYNC to the markset #10172

merged 1 commit into from
Feb 7, 2023

Conversation

ribasushi
Copy link
Collaborator

@ribasushi ribasushi commented Feb 1, 2023

Proposed Changes

Without doing this a badger markset on a non-nvme gets into so much I/O wait that it knocks a node hopelessly out of sync.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Without doing this walking a badger markset on a non-nvme knocks the
node hopelessly out of sync during a compaction.
@ribasushi ribasushi marked this pull request as ready for review February 1, 2023 20:56
@ribasushi ribasushi requested a review from a team as a code owner February 1, 2023 20:56
@William8Work
Copy link

when can we fix this? My daemon are having this issues twice now in last 7 days.

@magik6k magik6k merged commit e0d92a1 into filecoin-project:master Feb 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants