Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ci: Debugging m1 build #10749

Merged
merged 3 commits into from
May 10, 2023
Merged

fix: ci: Debugging m1 build #10749

merged 3 commits into from
May 10, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 25, 2023

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the ci/1.23-release-artifacts branch 3 times, most recently from f682407 to d344ce3 Compare April 25, 2023 08:02
@magik6k
Copy link
Contributor Author

magik6k commented Apr 25, 2023

@@ -63,7 +63,7 @@ commands:
name: Install Rust
command: |
curl https://sh.rustup.rs -sSf | sh -s -- -y
- run: make deps lotus
- run: make deps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix

@@ -1063,6 +1061,7 @@ workflows:
branches:
only:
- /^release\/v\d+\.\d+\.\d+(-rc\d+)?$/
- /^ci\/.*$/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea

@magik6k magik6k marked this pull request as ready for review May 10, 2023 08:31
@magik6k magik6k requested a review from a team as a code owner May 10, 2023 08:31
@magik6k magik6k force-pushed the ci/1.23-release-artifacts branch from b9864f7 to 4302bc0 Compare May 10, 2023 08:32
@magik6k magik6k changed the title [DNM] ci: Debugging m1 build fix: ci: Debugging m1 build May 10, 2023
@magik6k magik6k merged commit ea9a8bf into master May 10, 2023
@magik6k magik6k deleted the ci/1.23-release-artifacts branch May 10, 2023 09:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants