Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change args check #10812

Merged
merged 3 commits into from
May 3, 2023
Merged

Change args check #10812

merged 3 commits into from
May 3, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented May 3, 2023

Proposed Changes

Change args check in lotus chain set cmd to make it possible to actually use the --epoch option and --genesis options. Regression from #10114.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Remove args check in `lotus chain set`
Changing to if args.present
@rjan90 rjan90 changed the title Remove args check Change args check May 3, 2023
Update args
@rjan90 rjan90 marked this pull request as ready for review May 3, 2023 18:52
@rjan90 rjan90 requested a review from a team as a code owner May 3, 2023 18:52
@rjan90 rjan90 merged commit 093d350 into master May 3, 2023
@rjan90 rjan90 deleted the fix/set-head-cmd branch May 3, 2023 18:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants