Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

libp2p: add QUIC and WebTransport to default listen addresses #10848

Merged
merged 1 commit into from
May 10, 2023

Conversation

marten-seemann
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@marten-seemann marten-seemann requested a review from a team as a code owner May 10, 2023 07:52
@marten-seemann marten-seemann force-pushed the libp2p-quic-webtransport branch from a174ba7 to 6ab9489 Compare May 10, 2023 08:23
@marten-seemann marten-seemann force-pushed the libp2p-quic-webtransport branch from 6ab9489 to 0a064c1 Compare May 10, 2023 09:07
@magik6k magik6k merged commit 4a155a9 into master May 10, 2023
@magik6k magik6k deleted the libp2p-quic-webtransport branch May 10, 2023 10:23
@Shekelme
Copy link

Why do we need QUIC and WebTransport (and Libp2p at all) on lotus-miner? It does not expose Libp2p AFAIK.

@jennijuju
Copy link
Member

This PR doesn’t have any description or test plan. It’s not clear to me what does this do for users

@aschmahmann
Copy link
Contributor

Note: from what I can tell this closes out #10122.

@jennijuju
Copy link
Member

Note: from what I can tell this closes out #10122.

That does sounds useful 👍🏻 seems like a thing useful for node operators tho , agree with @Shekelme its not clear to me why we wanna open it on miner

@magik6k
Copy link
Contributor

magik6k commented Aug 17, 2023

Why do we need QUIC and WebTransport (and Libp2p at all) on lotus-miner

This is only when you have the legacy markets subsystem enabled. WebTransport allows in-browser nodes to connect to your node without the need for special setup

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants