Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

release: v1.24.0-rc4 #11375

Merged
merged 9 commits into from
Nov 1, 2023
Merged

release: v1.24.0-rc4 #11375

merged 9 commits into from
Nov 1, 2023

Conversation

jennijuju
Copy link
Member

backports
#11371
#11354
#11373
#11357

this rc also sets the mainnet upgrade at epoch 3431940

snissn and others added 7 commits November 1, 2023 15:10
@snissn @Stebalien
add support for v12 check invariants and also a default case to reduc…
389dc28 
…e future confusion (#11371)
@Stebalien
fix: api: compute the effective gas cost with the correct base-fee (#…
56b0348 
…11357)

fixes #11252
@Stebalien
fix: api: compute gasUsedRatio based on max gas in the tipset (#11354)
3a74a24 
We were computing this based on the max block gas, but this is
incorrect. The new value isn't entirely correct either (we should
probably compute an average of the gas used in each block in the
tipset?), but it's good enough.

fixes #10515
@arajasek @Stebalien
fix: sync: iterate over returned messages directly (#11373)
71ba2e4
@Stebalien
update both mainnet and calib upgrade epoch
ba79d56
@Stebalien
update version
d8b63c7
@jennijuju @Stebalien
docs gen
7c0e9ea
@jennijuju jennijuju requested a review from a team as a code owner November 1, 2023 22:28
@jennijuju jennijuju changed the title release: v1.24.0-rc3 release: v1.24.0-rc4 Nov 1, 2023
Stebalien
Stebalien approved these changes Nov 1, 2023
View reviewed changes
build/params_mainnet.go
// ???????
var UpgradeWatermelonHeight = abi.ChainEpoch(9999999999)
// 2023-11-29T13:30:00Z
var UpgradeWatermelonHeight = abi.ChainEpoch(3431940)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AKA

PST Wed Nov 29 05:30:00 2023
UTC Wed Nov 29 13:30:00 2023

arajasek
arajasek reviewed Nov 1, 2023
View reviewed changes
@arajasek
Copy link
Contributor

arajasek commented Nov 1, 2023

Can I ask someone to examine the v12.tar.zst file with this PR, and confirm that:

  • it includes TWO calibrationnet bundles, called builtin-actors-calibrationnet.car and builtin-actors-calibrationnet-buggy.car
  • builtin-actors-calibrationnet.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs
  • builtin-actors-calibrationnet-buggy.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs
  • builtin-actors-mainnet.car has a manifest CID of bafy2bzacecooh5cjxkmraawn7wvmrx7k5hwdmbvqdteujr33mnaeclsazyb6a

@jennijuju jennijuju force-pushed the jen/rc3-prep branch 2 times, most recently from b3870d0 to f903dc4 Compare November 1, 2023 22:59
@jennijuju
Copy link
Member Author

  • builtin-actors-calibrationnet.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs
  • builtin-actors-calibrationnet-buggy.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs

Im being paranoid as you demanded and check the bundles. Calib buggy and mainnet matches what you suggested - and I assume you meant a different calibration non buggy cid which ends kzru(in your message they are dupes)

@jennijuju jennijuju merged commit ee0152f into release/v1.24.0 Nov 1, 2023
@jennijuju jennijuju deleted the jen/rc3-prep branch November 1, 2023 23:44
@jennijuju jennijuju mentioned this pull request Nov 2, 2023
Merged
@arajasek
Copy link
Contributor

arajasek commented Nov 2, 2023

  • builtin-actors-calibrationnet.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs
  • builtin-actors-calibrationnet-buggy.car has a manifest CID of bafy2bzacedrunxfqta5skb7q7x32lnp4efz2oq7fn226ffm7fu5iqs62jkmvs

Im being paranoid as you demanded and check the bundles. Calib buggy and mainnet matches what you suggested - and I assume you meant a different calibration non buggy cid which ends kzru(in your message they are dupes)

I did in fact mean that! Thank you! 💙

@irinazheltisheva irinazheltisheva mentioned this pull request Mar 22, 2024
Open
This was referenced May 13, 2024
Open
Open
Open
@irinazheltisheva irinazheltisheva mentioned this pull request May 22, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennijuju @arajasek @Stebalien @snissn