Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

migrate-fix #11418

Merged
merged 1 commit into from
Nov 15, 2023
Merged

migrate-fix #11418

merged 1 commit into from
Nov 15, 2023

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Nov 14, 2023

Related Issues

getInfo() implemented

Proposed Changes

I implemented this as requested, but I'm still seeing the repo lock fail, so I think the migrator needs some different handling there.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from a team as a code owner November 14, 2023 21:35
@snadrus snadrus requested a review from magik6k November 14, 2023 21:35
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement

@magik6k magik6k merged commit 1a9e3cf into feat/lp-winning Nov 15, 2023
@magik6k magik6k deleted the sturdy-migrate-fixes branch November 15, 2023 11:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants