Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: miner info: Show correct sector state counts #11456

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 23, 2023

Related Issues

Fixes a small regression from #11353

Proposed Changes

Additional Info

Before this fix lotus-miner info would show zero counts for states through which at least one sector has passed since starting the miner process:

Sectors:
	Total: 8268
	Proving: 3194
	Available: 165
	WaitDeals: 0
	AddPiece: 1
	: 0
	Packing: 0
	GetTicket: 0
	PreCommit1: 11
	Committing: 0
	CommitFinalize: 0
	SubmitCommit: 0
	CommitWait: 1
	FinalizeSector: 0
	Removed: 4896

After this PR:

Sectors:
	Total: 8269
	Proving: 3194
	Available: 165
	AddPiece: 1
	Packing: 1
	PreCommit1: 11
	CommitWait: 1
	Removed: 4896

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner November 23, 2023 20:22
@magik6k magik6k requested review from snissn and arajasek November 23, 2023 20:22
@magik6k magik6k force-pushed the fix/mineinfo-counts branch from 91c23ab to 3407848 Compare November 23, 2023 20:23
@jennijuju
Copy link
Member

can we add a test please? so to make sure such regression could be caught next time?

@magik6k
Copy link
Contributor Author

magik6k commented Nov 24, 2023

This code won't exist in lotus-provider world

@jennijuju
Copy link
Member

This code won't exist in lotus-provider world

I strongly push back on this. Lotus miner functionalities shouldn’t be broken and well maintained until if not lotus provider is proven to be adopted by a decent amount of users, at least production ready. Needlessly to say, today lotus provider is not even shipped in any form.

@snadrus snadrus merged commit 3283cb7 into master Nov 27, 2023
@snadrus snadrus deleted the fix/mineinfo-counts branch November 27, 2023 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants