Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: commit batch: Always go through commit batcher #11704

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 11, 2024

Related Issues

Proposed Changes

  • Deprecate old commit path which didn't use DDO-compatible methods
  • Make commit batcher work in non-batch mode when configured like so

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 11, 2024 17:18
@magik6k magik6k force-pushed the fix/lm-commit-batch-ddo branch from 05f7bcd to cf3d67c Compare March 11, 2024 17:30
@magik6k magik6k mentioned this pull request Mar 11, 2024
8 tasks
@jennijuju jennijuju requested review from snadrus and LexLuthr March 12, 2024 08:41
@LexLuthr LexLuthr force-pushed the fix/lm-commit-batch-ddo branch from 30ff0e5 to 26ef58a Compare March 12, 2024 13:10
@LexLuthr LexLuthr changed the base branch from release/v1.26.0 to master March 12, 2024 13:10
@snadrus snadrus merged commit 2d80e75 into master Mar 12, 2024
90 checks passed
@snadrus snadrus deleted the fix/lm-commit-batch-ddo branch March 12, 2024 16:11
rjan90 pushed a commit that referenced this pull request Mar 13, 2024
* fix: commit batch: Always go through commit batcher

* fix sealing fsm tests
rjan90 added a commit that referenced this pull request Mar 13, 2024
* enable storing events (#11712)

* fix: commit batch: Always go through commit batcher (#11704)

* fix: commit batch: Always go through commit batcher

* fix sealing fsm tests

* sealing pipeline: Fix panic on padding pieces in WaitDeals (#11708)

* sealing pipeline: Fix panic on padding pieces in WaitDeals

* sealing pipeline: Catch panics

* sealing pipeline: Output DDO pieces in SectorStatus (#11709)

* sealing pipeline: Fix failing ProveCommit3 aggregate (#11710)

* itests: Repro failing ProveCommit3 aggregate

* commit batch: Correctly sort sectors in processBatchV2

* fix imports

* ci: Bigger instance for sector_pledge test

* itests: Use Must-Post mining in TestPledgeBatching

---------

Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
rjan90 added a commit that referenced this pull request Mar 22, 2024
* enable storing events (#11712)

* fix: commit batch: Always go through commit batcher (#11704)

* fix: commit batch: Always go through commit batcher

* fix sealing fsm tests

* sealing pipeline: Fix panic on padding pieces in WaitDeals (#11708)

* sealing pipeline: Fix panic on padding pieces in WaitDeals

* sealing pipeline: Catch panics

* sealing pipeline: Output DDO pieces in SectorStatus (#11709)

* sealing pipeline: Fix failing ProveCommit3 aggregate (#11710)

* itests: Repro failing ProveCommit3 aggregate

* commit batch: Correctly sort sectors in processBatchV2

* fix imports

* ci: Bigger instance for sector_pledge test

* itests: Use Must-Post mining in TestPledgeBatching

---------

Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants