src: lint: bump golangci-lint to 1.59, address unchecked fmt.Fprint*

[rvagg]

Another attempt at bumping the linter.

In 1.59, they removed a blanket Ignore: "fmt:.*", and instead now rely on a more targeted ignore set of rules based on the types that fmt.Fprint*() prints into. The main reason this bites us hard here is because when we print from urfave/cli Command runners, we use the built-in context AppWriter and ErrWriter. AppWriter is usually os.Stdout which is not excluded in the new rules, ErrWriter is usually os.Stderr but it could also be something else and the new rules can't differentiate and neither can we.

I'm fine with the more targeted ruleset. It means having to opt-in to ignores if you have good reason to. Mostly I've gone with _, _ = ignores, but there's a few places of blocks of fmt.Fprintf lines where I've gone with //nolint:errcheck.

In terms of landing this, it will have conflicts with the markets removal PRs, notably there's a big change set in paych.go which is disappearing with those PRs. This PR isn't urgent and it may be easier to rebase this on those changes once they land than the other way around.

[github-actions]

All checks have completed

❌ Failed Test / Test (itest-manual_onboarding) (pull_request)

[rjan90]

In terms of landing this, it will have conflicts with the markets removal PRs, notably there's a big change set in paych.go which is disappearing with those PRs. This PR isn't urgent and it may be easier to rebase this on those changes once they land than the other way around.

Agree on landing this PR after the markets removal PR has landed.