Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: nv25 network skeleton #12707

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Nov 19, 2024

Related Issues

Closes #12686

Checklist

Before you mark the PR ready for review, please make sure that:

@BigLep BigLep requested a review from rjan90 November 21, 2024 19:23
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Nov 22, 2024
@rjan90
Copy link
Contributor

rjan90 commented Nov 22, 2024

Doing a test run in a devnet:

Network version at the start of the devnet:

lotus state actor-cids
Network Version: 24
Actor Version: 15
Manifest CID: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug
----

I can see that the pre-migration happens on my node, as well as the actual migration at epoch 200:

2024-11-22T13:05:33.869+0100    WARN    statemgr        stmgr/forks.go:202      STARTING migration      {"height": "200", "from": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s"}
2024-11-22T13:05:33.869+0100    INFO    bundle  bundle/bundle.go:60     manifest cid: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug
------
2024-11-22T13:05:33.869+0100    INFO    fil-consensus   filcns/upgrades.go:3001 All 17 done after 132.917µs (127899/s)
2024-11-22T13:05:33.869+0100    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s", "to": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s", "duration": 0.000383541}

See that we switch actors-bundle version and network version:

lotus state actor-cids
Network Version: 25
Actor Version: 16
Manifest CID: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug

And the network is able to progress after upgrade epoch:

228: (Nov 22 13:07:20) [ bafy2bzacecl4id5ktip33yrbdmy23kxpdqbmopefhfbkihdtnw4enkc54327y: t01000, ]
229: (Nov 22 13:07:24) [ bafy2bzacecynlqv5bqrsgjrnjhrj233j553vru5g3pjvwyofvgmo7mpgwk7re: t01000, ]
230: (Nov 22 13:07:28) [ bafy2bzacebex5hvdhzhjnf4vtu6dbnom7vmvuxcalae6kzlcyap2kxaeyn26o: t01000, ]
231: (Nov 22 13:07:32) [ bafy2bzacedkwqxoutgcbpnz4wb7azlpbsgh2ptfghhcb7mnrmnkeolxngnsfq: t01000, ]

@rvagg
Copy link
Member

rvagg commented Nov 25, 2024

  • lint & migration test failure can be fixed with my suggestion - var instead of const for that one
  • gateway test failure is a known flaky
  • eth_transactions test failure is odd, but very likely unrelated to this - let's see how it goes when a change is pushed here and it reruns.

@kamuik16
Copy link
Contributor Author

  • lint & migration test failure can be fixed with my suggestion - var instead of const for that one
  • gateway test failure is a known flaky
  • eth_transactions test failure is odd, but very likely unrelated to this - let's see how it goes when a change is pushed here and it reruns.

the var instead of const created some kind of a havoc in the CI.

@rvagg
Copy link
Member

rvagg commented Nov 25, 2024

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

@kamuik16
Copy link
Contributor Author

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

It didn't

@kamuik16
Copy link
Contributor Author

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

But solved it somehow.

@kamuik16
Copy link
Contributor Author

@rjan90, @rvagg the CI is green, do you want to run the devnet sim again or is it good to go?

@rjan90
Copy link
Contributor

rjan90 commented Nov 25, 2024

@rjan90, @rvagg the CI is green, do you want to run the devnet sim again or is it good to go?

I will re-run just for sanity

@rjan90
Copy link
Contributor

rjan90 commented Nov 25, 2024

Confirming that the sanity check of re-running a devnet with the final changes was good.

Seeing the migration complete:

2024-11-25T09:42:20.954+0100    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzacebxw32mnbrbt6clzdncha2uxwzztkw4jrxebu4ddf3r7e2ktytumq", "to": "bafy2bzacebxw32mnbrbt6clzdncha2uxwzztkw4jrxebu4ddf3r7e2ktytumq", "duration": 0.000398791}

And the chain progresses after the nv25 upgrade:

222: (Nov 25 09:43:42) [ bafy2bzaceczz2xxnl6kibjzybnlex473ccfi5qsqvwgs6wayhru2a5l3uzasg: t01000, ]
223: (Nov 25 09:43:46) [ bafy2bzaced76rk4m22qnqhjdmqbsyt4eh3vversdc3qvwaqxaeido77pviqw2: t01000, ]
224: (Nov 25 09:43:50) [ bafy2bzacedxyhv5zwnefcxg73c5yb52het56qkrdgqpscfffy7sbkcxduh5ge: t01000, ]
225: (Nov 25 09:43:54) [ bafy2bzacebinngor2nykaxpcjn44vzx4j4tj3hwtjo2xtfvn6ixjzd4i44waq: t01000, ]
226: (Nov 25 09:43:58) [ bafy2bzacecoznvx4tx4m7piirovs56yoescsmvytfmo7jbetqx46l2jf3zqjo: t01000, ]

@rjan90 rjan90 merged commit b0de2bd into filecoin-project:master Nov 25, 2024
83 checks passed
@kamuik16 kamuik16 deleted the nv25-skeleton branch November 25, 2024 08:49
virajbhartiya pushed a commit to virajbhartiya/lotus that referenced this pull request Nov 28, 2024
* chore: update dependencies and stuff

* update stuff part 2

* chore: make gen

* chore: update UpgradeTuktukHeight to var

* chore: make actors-gen
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

Skeleton for nv25 to support development and testing
3 participants