Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: infra/ci: add lotus-test image as CI build step #7956

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Jan 14, 2022

This PR is:

  1. Adding a lotus-test Docker target to Dockerfile.lotus
  2. Build step to produce lotus-test image on commit to master.

We need this, because we are using the --tags=debug lotus binaries as part of the integration tests for Boost -- https://github.com/filecoin-project/boost/blob/main/.circleci/config.yml#L67

Ideally these images should be produced by filecoin-project/lotus build system.


TODO:

  • create public ECR repository for lotus-test, same as lotus-dev.

@nonsense nonsense force-pushed the nonsense/add-lotus-test-image-building branch from eaf3eab to 5ccc714 Compare January 14, 2022 14:25
@nonsense
Copy link
Member Author

nonsense commented Jan 14, 2022

@travisperson provided this PR is accepted, could you help create the repository on the AWS account (same as lotus-dev)?

This will address the failure on build-and-push-image-2.

@nonsense nonsense marked this pull request as ready for review January 14, 2022 14:47
@nonsense nonsense requested a review from a team as a code owner January 14, 2022 14:47
@jennijuju
Copy link
Member

Please update the title according to the PR template!

- [ ] The PR title is in the form of of `<PR type>: <area>: <change being made>`

@nonsense nonsense changed the title add lotus-test image as CI build step feat: infra/ci: add lotus-test image as CI build step Feb 4, 2022
@nonsense nonsense force-pushed the nonsense/add-lotus-test-image-building branch from 382be3f to 2affaaf Compare March 3, 2022 14:50
@nonsense
Copy link
Member Author

nonsense commented Mar 8, 2022

@magik6k @travisperson any chance we can push this forward? It will be handy if we have up-to-date docker images for dependent projects, such as Boost.

We need:

  1. public ECR repo for the image
  2. merge of this PR so that we start pushing images to the ECR repo

@travisperson
Copy link
Contributor

Yes, I will create the lotus-test repo

@nonsense nonsense force-pushed the nonsense/add-lotus-test-image-building branch from 2affaaf to fee69a8 Compare March 21, 2022 07:41
@magik6k magik6k merged commit efdcd00 into master Mar 21, 2022
@magik6k magik6k deleted the nonsense/add-lotus-test-image-building branch March 21, 2022 09:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants