Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix handlePreCommitFailed: PreCommitMessage is not nil, but SectorPre… #8310

Closed

Conversation

llifezou
Copy link
Contributor

Related Issues

#8307

@llifezou llifezou requested a review from a team as a code owner March 14, 2022 07:27
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

}

// PreCommitMessage is not nil, but SectorPreCommitInfo is nil, should try to resubmit
if pci == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be nil after the message was submitted but wasn't yet executed on-chain (which can take 1-2min)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreCommitMessage is not nil, it should be possible to determine whether the status is jumped from PreCommitWait or PreCommitBatchWait to PreCommitFailed

Copy link
Contributor Author

@llifezou llifezou Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In func(m *Sealing) handlePreCommitWait, I understand that StateWaitMsg should block until query result or return err, is it so?

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.32%. Comparing base (362c73b) to head (a3cf74e).
Report is 6728 commits behind head on master.

Files with missing lines Patch % Lines
extern/storage-sealing/states_failed.go 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8310      +/-   ##
==========================================
- Coverage   40.34%   40.32%   -0.03%     
==========================================
  Files         679      679              
  Lines       73961    73968       +7     
==========================================
- Hits        29842    29830      -12     
- Misses      38897    38913      +16     
- Partials     5222     5225       +3     
Files with missing lines Coverage Δ
extern/storage-sealing/states_failed.go 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

@rjan90
Copy link
Contributor

rjan90 commented Jan 10, 2025

Hey! 👋

As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR?

1. Close it: If it's no longer needed.
2. Mark as Draft: If it needs more work, and add the next steps.
3. Ready for Review: If it's good to go, let me know, and I'll assign a reviewer.

If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know.

Thanks for your help in keeping things organized, and I appreciate your contributions!

@llifezou llifezou closed this Jan 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants