-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix handlePreCommitFailed: PreCommitMessage is not nil, but SectorPre… #8310
Conversation
…CommitInfo is nil, should try to resubmit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
} | ||
|
||
// PreCommitMessage is not nil, but SectorPreCommitInfo is nil, should try to resubmit | ||
if pci == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be nil after the message was submitted but wasn't yet executed on-chain (which can take 1-2min)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PreCommitMessage is not nil, it should be possible to determine whether the status is jumped from PreCommitWait or PreCommitBatchWait to PreCommitFailed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In func(m *Sealing) handlePreCommitWait
, I understand that StateWaitMsg
should block until query result or return err, is it so?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8310 +/- ##
==========================================
- Coverage 40.34% 40.32% -0.03%
==========================================
Files 679 679
Lines 73961 73968 +7
==========================================
- Hits 29842 29830 -12
- Misses 38897 38913 +16
- Partials 5222 5225 +3
|
Hey! 👋 As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR? 1. Close it: If it's no longer needed. If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know. Thanks for your help in keeping things organized, and I appreciate your contributions! |
Related Issues
#8307