Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add an "unregister" function for observers #8445

Closed
wants to merge 1 commit into from

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien requested a review from a team as a code owner April 6, 2022 17:47
@Stebalien Stebalien marked this pull request as draft April 6, 2022 17:48
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #8445 (895e770) into master (f378c6d) will increase coverage by 6.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8445      +/-   ##
==========================================
+ Coverage   34.56%   40.62%   +6.06%     
==========================================
  Files         681      686       +5     
  Lines       75174    75413     +239     
==========================================
+ Hits        25984    30637    +4653     
+ Misses      44340    39471    -4869     
- Partials     4850     5305     +455     
Impacted Files Coverage Δ
chain/events/observer.go 66.20% <0.00%> (-0.22%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
extern/sector-storage/sched_worker.go 79.41% <0.00%> (-0.59%) ⬇️
chain/types/blockheader.go 55.55% <0.00%> (ø)
lib/nullreader/reader.go 0.00% <0.00%> (ø)
journal/mockjournal/journal.go 71.42% <0.00%> (ø)
chain/actors/builtin/paych/mock/mock.go 71.42% <0.00%> (ø)
chain/vectors/gen/main.go 2.36% <0.00%> (ø)
markets/dagstore/mocks/mock_lotus_accessor.go 80.48% <0.00%> (ø)
extern/sector-storage/mock/mock.go 60.20% <0.00%> (+0.25%) ⬆️
... and 162 more

@Stebalien Stebalien closed this Apr 6, 2022
@rjan90 rjan90 deleted the steb/observer-dereg branch January 31, 2025 08:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant