Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: cli: lotus client list-asks --protocols #8464

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 11, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner April 11, 2022 17:51
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #8464 (6bef1ae) into master (66f8877) will decrease coverage by 0.02%.
The diff coverage is 48.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8464      +/-   ##
==========================================
- Coverage   40.70%   40.68%   -0.03%     
==========================================
  Files         686      686              
  Lines       75476    75495      +19     
==========================================
- Hits        30723    30713      -10     
- Misses      39450    39472      +22     
- Partials     5303     5310       +7     
Impacted Files Coverage Δ
api/api_full.go 57.89% <ø> (ø)
cli/client.go 22.15% <15.38%> (-0.24%) ⬇️
api/v0api/v1_wrapper.go 15.30% <60.00%> (+1.25%) ⬆️
node/impl/client/client.go 51.65% <81.81%> (+0.28%) ⬆️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/events/observer.go 73.79% <0.00%> (-7.59%) ⬇️
extern/sector-storage/stores/index_locks.go 71.42% <0.00%> (-5.96%) ⬇️
miner/miner.go 54.75% <0.00%> (-5.25%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
... and 21 more

@magik6k magik6k merged commit ac57797 into master Apr 12, 2022
@magik6k magik6k deleted the feat/getask-protos branch April 12, 2022 08:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants