Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add api endpoint to remove retirevals #8525

Closed
wants to merge 2 commits into from

Conversation

coryschwartz
Copy link

fixes: #8414

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@rjan90
Copy link
Contributor

rjan90 commented Sep 10, 2024

Closing as outdated.

@rjan90 rjan90 closed this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 40.28%. Comparing base (88f8c7d) to head (bac5f7d).
Report is 5980 commits behind head on master.

Files with missing lines Patch % Lines
node/impl/client/client.go 41.66% 13 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8525      +/-   ##
==========================================
- Coverage   40.86%   40.28%   -0.59%     
==========================================
  Files         686      521     -165     
  Lines       75710    56438   -19272     
==========================================
- Hits        30939    22735    -8204     
+ Misses      39445    29732    -9713     
+ Partials     5326     3971    -1355     
Files with missing lines Coverage Δ
api/api_full.go 47.36% <ø> (-10.53%) ⬇️
node/impl/client/client.go 25.66% <41.66%> (-25.99%) ⬇️

... and 384 files with indirect coverage changes

@rjan90 rjan90 deleted the feat/remove-retrievals branch January 31, 2025 08:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add command to delete retrievals
2 participants