Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ux: update lotus-wallet run description #8528

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix: ux: update lotus-wallet run description #8528

merged 2 commits into from
Apr 25, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Apr 21, 2022

Proposed Changes

Update the lotus-wallet run description to include that a FULLNODE_API_INFO env variable needs to be set before running. Should address 5. in #8459

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Update the `lotus-wallet run` to include that a `FULLNODE_API_INFO` env variable needs to be set before running
@rjan90 rjan90 requested a review from a team as a code owner April 21, 2022 12:23
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #8528 (825cdb8) into master (caeeb6a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8528      +/-   ##
==========================================
- Coverage   40.26%   40.23%   -0.03%     
==========================================
  Files         683      683              
  Lines       74480    74480              
==========================================
- Hits        29989    29969      -20     
- Misses      39263    39275      +12     
- Partials     5228     5236       +8     
Impacted Files Coverage Δ
cmd/lotus-wallet/main.go 0.00% <ø> (ø)
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-5.41%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.47%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-0.85%) ⬇️
chain/sync.go 70.52% <0.00%> (-0.69%) ⬇️
extern/storage-sealing/fsm.go 60.73% <0.00%> (-0.68%) ⬇️
... and 13 more

@arajasek
Copy link
Contributor

BTW, you shouldn't need to fork the repo -- you should have write access as a member of the @filecoin-project/lotus-tse team.

Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
@rjan90 rjan90 merged commit 1162b02 into filecoin-project:master Apr 25, 2022
@rjan90 rjan90 deleted the ux/description-lotus-wallet branch April 25, 2022 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants