Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ci: build macos and linux assets on tagged releases #8597

Merged
merged 2 commits into from
May 6, 2022

Conversation

travisperson
Copy link
Contributor

@travisperson travisperson commented May 4, 2022

Related Issues

#8594

Proposed Changes

Add back the explicit call to build on tags that was removed in #8581

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@travisperson travisperson requested a review from a team as a code owner May 4, 2022 16:26
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #8597 (b83824b) into master (2478814) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8597      +/-   ##
==========================================
- Coverage   40.85%   40.75%   -0.11%     
==========================================
  Files         686      686              
  Lines       75710    75710              
==========================================
- Hits        30935    30855      -80     
- Misses      39452    39513      +61     
- Partials     5323     5342      +19     
Impacted Files Coverage Δ
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
blockstore/api.go 24.00% <0.00%> (-8.00%) ⬇️
miner/miner.go 54.42% <0.00%> (-5.25%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-3.93%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/stmgr/call.go 65.94% <0.00%> (-3.25%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
chain/events/events_called.go 85.85% <0.00%> (-2.44%) ⬇️
extern/storage-sealing/currentdealinfo.go 70.17% <0.00%> (-1.76%) ⬇️
blockstore/splitstore/splitstore_reify.go 55.37% <0.00%> (-1.66%) ⬇️
... and 19 more

@travisperson
Copy link
Contributor Author

travisperson commented May 4, 2022

This will build for tags as well as all PRs (see CI run of this PR for build-all and build-macos)

@jennijuju jennijuju changed the base branch from master to release/v1.15.2 May 6, 2022 05:58
@jennijuju jennijuju changed the base branch from release/v1.15.2 to master May 6, 2022 05:59
@jennijuju jennijuju merged commit c1f1d3d into master May 6, 2022
@jennijuju jennijuju deleted the fix/assert-build-on-tag branch May 6, 2022 05:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants