-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[nv16] niceties for development bundle loading #8658
Conversation
This is a nicety for development, so that we always load a development bundle to avoid having to give them distinct names etc. Just call you release "dev" or "dev.xxx..." and put the bundle in `.lotus/builtin-actors/v8/dev/builting-actors-${network}.{car,sha256sum}` and it will be unconditionally loaded.
unexpected test failures are from github hiccups:
|
we might want to cache |
@vyzo something seems to be broken in GitHub for builtin-actors because even release edit pages return a 404. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyzo It's a weird to rely on a string convention when we have a TOML schema to which we can add properties. I would suggest that if you want to treat a bundle as a development release, you should specify the dev = true
key for that bundle in its TOML table.
Also, we should add a path
attribute to load the bundle from the local filesystem when it's specified.
sure, can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the comments. Approving in anticipation, but @arajasek should comment too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
[nv16] flexible bundle loading
[nv16] use network bundle names consistent with the network name
This adds some niceties for development bundle loading; see the README.
Related Issues
See #8625