Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[nv16] niceties for development bundle loading #8658

Merged
merged 21 commits into from
May 17, 2022
Merged

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 16, 2022

This adds some niceties for development bundle loading; see the README.

Related Issues

See #8625

This is a nicety for development, so that we always load a development bundle to avoid having
to give them distinct names etc. Just call you release "dev" or "dev.xxx..." and put the bundle
in `.lotus/builtin-actors/v8/dev/builting-actors-${network}.{car,sha256sum}` and it will be
unconditionally loaded.
@vyzo vyzo requested review from raulk and arajasek May 16, 2022 12:13
@vyzo vyzo requested a review from a team as a code owner May 16, 2022 12:13
@vyzo
Copy link
Contributor Author

vyzo commented May 16, 2022

unexpected test failures are from github hiccups:

2022-05-16T12:13:33.093Z	ERROR	bundle-fetcher	bundle/bundle.go:59	error fetching bundle builtin-actors-mainnet: all attempts to fetch https://github.com/filecoin-project/builtin-actors/releases/download/b71c2ec785aec23d/builtin-actors-mainnet.sha256 failed
panic: error fetching bundle for builtin-actors version 8: error fetching bundle: all attempts to fetch https://github.com/filecoin-project/builtin-actors/releases/download/b71c2ec785aec23d/builtin-actors-mainnet.sha256 failed

goroutine 1 [running]:
github.com/filecoin-project/lotus/cli.init.0()
	/home/circleci/project/cli/init.go:19 +0x5a

Exited with code exit status 2

@vyzo
Copy link
Contributor Author

vyzo commented May 16, 2022

we might want to cache /tmp/lotus-testing in CI.

@raulk
Copy link
Member

raulk commented May 16, 2022

@vyzo something seems to be broken in GitHub for builtin-actors because even release edit pages return a 404.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyzo It's a weird to rely on a string convention when we have a TOML schema to which we can add properties. I would suggest that if you want to treat a bundle as a development release, you should specify the dev = true key for that bundle in its TOML table.

Also, we should add a path attribute to load the bundle from the local filesystem when it's specified.

@vyzo
Copy link
Contributor Author

vyzo commented May 16, 2022

sure, can do.

@vyzo vyzo changed the title [nv16] don't store dev bundle release keys in the datastore [nv16] niceties for development bundle loading May 16, 2022
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the comments. Approving in anticipation, but @arajasek should comment too.

vyzo and others added 9 commits May 16, 2022 21:38
Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: raulk <raul@protocol.ai>
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

vyzo and others added 3 commits May 16, 2022 22:42
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
@vyzo vyzo merged commit ee11018 into feat/nv16 May 17, 2022
@vyzo vyzo deleted the feat/nv16-dev-bundle branch May 17, 2022 19:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants