Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: set NetworkBundle in params file #8716

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

Stebalien
Copy link
Member

Related Issues

fixes #8684

Proposed Changes

Set NetworkBundle in params file instead of in the Makefile. Otherwise, we end up overriding the
ldflags.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner May 24, 2022 16:36
@Stebalien Stebalien requested a review from travisperson May 24, 2022 16:36
@Stebalien Stebalien force-pushed the fix/makefile-flags branch from 1b0ed07 to f7eb3c9 Compare May 24, 2022 16:41
Otherwise, we end up overriding the ldflags.

fixes #8684
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants