Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: cli: New commands for testing. #8719

Merged
merged 8 commits into from
May 25, 2022
Merged

Conversation

geoff-vball
Copy link
Contributor

Proposed Changes

Implements 3 new cli commands.
compact-paritions for general use. We never had a way to call this before.
send-invalid-windowed-post and generate-and-send-consensus-fault for testing purposes.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner May 24, 2022 18:35
@geoff-vball geoff-vball changed the title Gstuart/cli bad post feat: cli: New commands for testing. May 24, 2022
@geoff-vball geoff-vball force-pushed the gstuart/cli-bad-post branch from 39f8ee2 to 8d0f33f Compare May 24, 2022 18:41
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, nits galore.

@geoff-vball geoff-vball force-pushed the gstuart/cli-bad-post branch from fcdf64a to a29fe73 Compare May 25, 2022 18:48
@geoff-vball geoff-vball force-pushed the gstuart/cli-bad-post branch 2 times, most recently from 63231c7 to bd59e40 Compare May 25, 2022 19:41
@geoff-vball geoff-vball force-pushed the gstuart/cli-bad-post branch from bd59e40 to 7bf9ce2 Compare May 25, 2022 20:42
@geoff-vball geoff-vball merged commit 966f681 into feat/nv16 May 25, 2022
@geoff-vball geoff-vball deleted the gstuart/cli-bad-post branch May 25, 2022 21:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants