Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix:mpool add gaspremium check when less than maxfee #9497

Merged

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Oct 17, 2022

Related Issues

Proposed Changes

in current CapGasFee, skipp gaspremium check when fee is enough

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • [ x] Commits have a clear commit message.
  • [x ] PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@hunjixin hunjixin requested a review from a team as a code owner October 17, 2022 03:58
@hunjixin hunjixin changed the title fix: add gaspremium check when less than maxfee fix:mpool add gaspremium check when less than maxfee Oct 17, 2022
@hunjixin hunjixin force-pushed the fix/add_check_gaspremium branch from ee338a0 to e8aacf3 Compare October 17, 2022 04:03
@geoff-vball geoff-vball requested review from Kubuxu and magik6k October 27, 2022 12:07
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT assumming the CI is unaffected.

I also want to point out that this doesn't change any of the behaviours, as the cap of GasPremium is calculated when executing the message.

@hunjixin
Copy link
Contributor Author

hunjixin commented Nov 2, 2022

user may use a fixed GasPremium in message, this would skip gaspremium calculation

@magik6k magik6k merged commit 32efd0f into filecoin-project:master Nov 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants