test: nv17 migration #9549
Merged
test: nv17 migration #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/migration-integ-test
branch
from
ae635a5 to
21e85e3
Compare
geoff-vball
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Approved with a couple nits. This test led me to find filecoin-project/builtin-actors#784. I will add a check for it after this is merged.
itests/migration_nv17_test.go
Outdated
| claim, ok := claims[1] | ||
| require.True(t, ok) | ||
|
|
||
| claimerId, err := address.NewIDAddress(uint64(claim.Client)) |
There was a problem hiding this comment.
nit: now that we're using actorIds to index HAMTs, we should be more careful about what is an ID vs ID Adddress. This is an ID Address
41 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#9524, #9246
Proposed Changes
Covers all the cases in #9524 , and a few more
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps