Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

api: ethrpc: add missing fields #9631

Merged
merged 2 commits into from
Nov 12, 2022
Merged

api: ethrpc: add missing fields #9631

merged 2 commits into from
Nov 12, 2022

Conversation

ychiaoli18
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ychiaoli18 ychiaoli18 requested a review from a team as a code owner November 11, 2022 19:51
@vyzo vyzo requested review from Stebalien and vyzo November 12, 2022 03:42
@vyzo
Copy link
Contributor

vyzo commented Nov 12, 2022

Failing tests.

@Stebalien
Copy link
Member

  • itest: flake
  • docs/gen: make gen.

Stebalien
Stebalien approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a make gen.

@Stebalien Stebalien merged commit 8a7367f into feat/nv18-fevm Nov 12, 2022
@Stebalien Stebalien deleted the feat/nv18-fevm-fix branch November 12, 2022 17:44
@Stebalien
Copy link
Member

Thanks!

@LinZexiao LinZexiao mentioned this pull request Nov 15, 2022
Merged
3 tasks
@scotthconner scotthconner mentioned this pull request Dec 8, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@vyzo vyzo Awaiting requested review from vyzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ychiaoli18 @vyzo @Stebalien