feat: events: version the MessageReceipt structure. #9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
force-pushed
the
raulk/events-messagereceipt
branch
from
3954733 to
5be87c0
Compare
This is implemented as an internal version discriminator. An alternative would've been to turn MessageReceipt into an interface with two backing structs for v0 and v1. But that approach would've broken all usage sites. CBOR serde for MessageReceipt is no longer automatically generated. We use custom logic to deal with versioning in both directions. This logic uses the cborgen serde code as a basis.
raulk
force-pushed
the
raulk/events-messagereceipt
branch
from
5be87c0 to
8333b80
Compare
vyzo
reviewed
Nov 14, 2022
chain/types/message_receipt_cbor.go
Outdated
| return err | ||
| } | ||
| } else { | ||
| if err := cw.WriteMajorTypeHeader(cbg.MajNegativeInt, uint64(-mr.ExitCode-1)); err != nil { |
There was a problem hiding this comment.
woah, we need to be able to decode this in other languages too you know...
There was a problem hiding this comment.
This was generated by cborgen -- what is the concrete problem you see?
|
Cant we do something similar to the state tree? |
vyzo
approved these changes
Nov 15, 2022
vyzo
reviewed
Nov 15, 2022
|
Note test failure. |
Not worth it. I expect that to be optimized away by newtype compiler optimizations anyway. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented as an internal version discriminator. An alternative would've been to turn MessageReceipt into an interface with two backing structs for v0 and v1. But that approach would've broken all usage sites.
CBOR serde for MessageReceipt is no longer automatically generated. We use custom logic to deal with versioning in both directions. This logic uses the cborgen serde code as a basis.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps