_build_: Remove ECR image publishing #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely removes publishing to Amamzon ECR. ECR is a private docker repository (like DockerHub), but since it's private is can only be used internally by PL teams to launch lotus nodes on AWS infrastructure. No one currently seems to be using it. All the usual suspects (Boost, Lotus, Infra) have been asked specifically, and said they don't, and post has been made in the #engres channel to try and catch anyone else. No one responded saying we should save it.
geoff-vball
approved these changes
Nov 23, 2022
magik6k
approved these changes
Nov 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes publishing to Amamzon ECR. ECR is a private docker repository (like DockerHub), but since it's private is can only be used internally by PL teams to launch lotus nodes on AWS infrastructure. No one currently seems to be using it. All the usual suspects (Boost, Lotus, Infra) have been asked specifically, and said they don't, and a post has been made in the #engres channel to try and catch anyone else. No one responded saying we should save it.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps