Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: FEVM: signature validation cache for messages with Delegated signatures. #9916

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

raulk
Copy link
Member

@raulk raulk commented Dec 20, 2022

Related Issues

Signature cache entry was constructed with the wrong cache key which did not cover the signature.
Plus, a little bit of gofmt on touched files.

Proposed Changes

Cover the signature by relying on the CID from the SignedMessage, which for the Delegated signature type covers the signature.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@raulk raulk requested a review from a team as a code owner December 20, 2022 13:24
@jennijuju
Copy link
Member

Add a test plz?

@raulk
Copy link
Member Author

raulk commented Dec 20, 2022

@jennijuju It wouldn't be testing anything useful, just that the key is the CID + signature, which is exactly what the code says, so useless test. Plus, Lotus doesn't already have signature cache unit tests, or does it?

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right way to do it.

@raulk raulk merged commit d9c13f1 into feat/nv18-fevm Dec 20, 2022
@raulk raulk deleted the raulk/fix/delegated-sigcache branch December 20, 2022 22:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants