Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: reduce default oct rows to discard from 3 to 2 #88

Closed
wants to merge 1 commit into from

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

@cryptonemo cryptonemo requested a review from porcuquine June 15, 2020 13:24
@cryptonemo
Copy link
Collaborator Author

Alternatively, we can do what we need to do without touching merkle_light, by just not using the default method here, and instead having our own default method in rust-fil-proofs (that uses the settings, etc)

Copy link

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this as the expedient way to change the default as desired for a short-term release. However, I think longer-term this default should not be set here. The 'right' default is dependent on usage and may change for reasons unrelated to the merkle_light implementation. (For example, if/when we optimize regenerating bottom tree segments, discarding more may make sense.)

@cryptonemo
Copy link
Collaborator Author

Closing in favor of filecoin-project/rust-fil-proofs#1165

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants