Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ethereum JSON-RPC: signatures -- validate value of V #1335

Closed
raulk opened this issue Dec 19, 2022 · 3 comments
Closed

Ethereum JSON-RPC: signatures -- validate value of V #1335

raulk opened this issue Dec 19, 2022 · 3 comments

Comments

@raulk
Copy link
Member

raulk commented Dec 19, 2022

V corresponds to the public key recovery coordinates selector for the ECDSA signature on the elliptic curve function. See https://bitcoin.stackexchange.com/questions/38351/ecdsa-v-r-s-what-is-v. There are only some values possible in Ethereum, and I think they might have even changed over time (but I'm not sure if this was Ethereum or Bitcoin).

Whoever takes this issue should check:

  1. Which V values are legal in Ethereum.
  2. That we validate that only legal values are used in signatures received through the Eth JSON-RPC eth_sendRawTransaction operation.
@maciejwitowski
Copy link
Contributor

@raulk can you set milestone and priority? Thanks!

@raulk
Copy link
Member Author

raulk commented Jan 4, 2023

@ychiaoli18 description added.

@raulk
Copy link
Member Author

raulk commented Jan 12, 2023

Merged in filecoin-project/lotus#9970.

@raulk raulk closed this as completed Jan 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants