Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

nit: fix naming #1805

Merged
merged 2 commits into from
Jan 7, 2025
+4 −2
Merged

nit: fix naming #1805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9ef846
fix naming
zhiqiangxu Jun 30, 2023
e5443a8
update changelog
Stebalien Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shared/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased]

- Rename `window_post_partitions_sectors` on both the `RegisteredPoStProof` and `RegisteredSealProof` types to `window_post_partition_sectors` to match the builtin actors (from @zhinqiangxu). This is a small breaking change.

## 4.5.3 [2024-12-04]

- chore: remove the nv25-dev feature flag [#2093](https://github.com/filecoin-project/ref-fvm/pull/2093)
Expand Down
4 changes: 2 additions & 2 deletions shared/src/sector/registered_proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ impl RegisteredPoStProof {
}
/// Returns the partition size, in sectors, associated with a proof type.
/// The partition size is the number of sectors proven in a single PoSt proof.
pub fn window_post_partitions_sector(self) -> Result<u64, String> {
pub fn window_post_partition_sectors(self) -> Result<u64, String> {
// Resolve to post proof and then compute size from that.
use RegisteredPoStProof::*;
match self {
Expand Down Expand Up @@ -219,7 +219,7 @@ impl RegisteredSealProof {

/// Returns the partition size, in sectors, associated with a proof type.
/// The partition size is the number of sectors proven in a single PoSt proof.
pub fn window_post_partitions_sector(self) -> Result<u64, String> {
pub fn window_post_partition_sectors(self) -> Result<u64, String> {
// Resolve to seal proof and then compute size from that.
use RegisteredSealProof::*;
match self {
Expand Down
Loading