fix: fix read syscall and sdk method #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
May 19, 2022
Stebalien
commented
- Return the correct offset (relative to the end of the logical buffer, not relative to the end of the bytes read).
- Don't cast "remaining" to a usize in read_block as it can be negative.
- Add an exhaustive test.
Stebalien
force-pushed
the
fix/sdk-read-block
branch
from
fc36827 to
4f06225
Compare
Stebalien
commented
May 19, 2022
|
|
||
| #[no_mangle] | ||
| pub fn invoke(_: u32) -> u32 { | ||
| std::panic::set_hook(Box::new(|info| { |
There was a problem hiding this comment.
This just makes debugging a lot easier.
1. Return the correct offset (relative to the end of the logical buffer, not relative to the end of the bytes read). 2. Don't cast "remaining" to a usize in read_block as it can be negative. 3. Add an exhaustive test. Found by @wadealexc.
Stebalien
force-pushed
the
fix/sdk-read-block
branch
from
4f06225 to
7a2671c
Compare
|
Yeah, that'll give us quite a bit of coverage. But we still need integration tests like this to get syscall (mostly concerning illegal arguments, etc.) and sdk coverage. |
wadealexc
reviewed
May 23, 2022
|
Looks good to me. My one nit is that the I don't think that the cases being covered by these are currently possible, though. |
This costs next to nothing, and is a good safety check.
vyzo
approved these changes
May 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.