Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test failure on stacked_vanilla_test_stacked_porep_prove_verify #1512

Closed
cryptonemo opened this issue Sep 30, 2021 · 0 comments · Fixed by #1515
Closed

Test failure on stacked_vanilla_test_stacked_porep_prove_verify #1512

cryptonemo opened this issue Sep 30, 2021 · 0 comments · Fixed by #1515

Comments

@cryptonemo
Copy link
Collaborator

Description

Running RUST_LOG=trace FIL_PROOFS_USE_GPU_TREE_BUILDER=1 RUSTFLAGS="-C target-cpu=native" cargo test --test stacked_vanilla test_stacked_porep_prove_verify fails.

Acceptance criteria

Fix this test, or find out why it's failing.

Risks + pitfalls

Where to begin
@dignifiedquire dignifiedquire mentioned this issue Oct 4, 2021
Merged
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: restrict StackedDrg to Poseidon hasher
6d721e1 
The GPU implementation only supports Poseidon hashing and within Filecoin
only Poseidon hashes are used for Stacked DRG. Hence restrict the
implementation to the Poseidon hasher.

Closed #1512.
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use GPU tree builder only for Poseidon hashes
389c7f9 
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).

Closes #1512.
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use more concrete types
9d6ab78 
The GPU tree builder only supports Poseidon hashes. In the current PoRep,
only Poseidon hashes are used, hence use concrete types instead, so that
errors/mis-use occur at compile-time and not at run-time.

Closes #1512.
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use GPU tree builder only for Poseidon hashes
f46813d 
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).

Closes #1512.
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use GPU tree builder only for Poseidon hashes
d863a06 
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).

Closes #1512.
@vmx vmx mentioned this issue Oct 5, 2021
Merged
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use GPU tree builder only for Poseidon hashes
0ebe6b7 
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).

Closes #1512.
@vmx vmx closed this as completed in #1515 Oct 5, 2021
vmx added a commit that referenced this issue Oct 5, 2021
@vmx
fix: use GPU tree builder only for Poseidon hashes (#1515)
0daa536 
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).

Closes #1512.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use GPU tree builder only for Poseidon hashes filecoin-project/rust-fil-proofs
1 participant
@cryptonemo