Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

no log output when retrieving a piece using libfilecoin_proofs.a #650

Closed
laser opened this issue May 9, 2019 · 4 comments · Fixed by #1137
Closed

no log output when retrieving a piece using libfilecoin_proofs.a #650

laser opened this issue May 9, 2019 · 4 comments · Fixed by #1137
Assignees
@laser
Labels
A-filecoin-proofs bug Something isn't working good first issue Good for newcomers

Comments

@laser
Copy link
Contributor

laser commented May 9, 2019

Description

FFI exposed functions should log when called and right before they return. The read_piece_from_sealed_sector function does not do this, and internal.rs::get_unsealed_range function doesn't log anything either.
@laser laser self-assigned this May 9, 2019
@laser laser added the bug Something isn't working label May 9, 2019
@laser laser removed their assignment Jun 4, 2019
@vmx
Copy link
Contributor

vmx commented Jun 14, 2019

@laser I guess you mean logging calls like this one?

https://github.com/filecoin-project/rust-fil-sector-builder/blob/1b75bf929bc6a868ef82465b4d0ff2d5a8bb9bff/sector-builder-ffi/src/api.rs#L309

There's plenty of those missing.

@vmx vmx added the good first issue Good for newcomers label Jun 14, 2019
@laser
Copy link
Contributor Author

laser commented Jun 14, 2019

@vmx I do indeed. I think the *_destroy_* calls can be skipped - but everything else should be INFO-level logged.

@vmx
Copy link
Contributor

vmx commented Jun 21, 2019

@laser I think logging even in the *_destroy_* (perhaps debug level) would make sense as this is where memory leaks happen if things go wrong.

@laser
Copy link
Contributor Author

laser commented Jun 22, 2019

@vmx Sounds good to me.

@laser laser self-assigned this Jul 19, 2019
@tcharding tcharding mentioned this issue Jun 1, 2020
Merged
cryptonemo pushed a commit that referenced this issue Jun 18, 2020
@tcharding
fix(filecoin-proofs): add logging to all public API functions (#1137)
96755e8 
From the issue description: "FFI exposed functions should log when called and right before they return."

Add logging to all the public functions (excl. public trait implementations) within the `api` module.

Closes: #650
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@laser laser

Labels
A-filecoin-proofs bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(filecoin-proofs): add logging to all public API functions
3 participants
@vmx @dignifiedquire @laser